Updating dio_read_verify ZTS test #16830
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
behlendorf
approved these changes
Dec 2, 2024
amotin
reviewed
Dec 3, 2024
bwatkinson
force-pushed
the
dio_read_verify_cleanup
branch
from
2b5d806 to
e85ba3d
Compare
Fine by me. I just updated the ordering of the checks in the test case. |
amotin
approved these changes
Dec 4, 2024
There was a recent CI ZTS test failure on FreeBSD 14 for the dio_read_verify test case. The failure reported there was no ARC reads while the buffer wes being manipulated. All checksum verify errors for Direct I/O reads are rerouted through the ARC, so there should be ARC reads accounted for. In order to help debug any future failures of this test case, the order of checks has been changed. First there is a check for DIO verify failures for the reads and then ARC read counts are checked. This PR also contains general cleanup of the comments in the test script. Signed-off-by: Brian Atkinson <[email protected]>
bwatkinson
force-pushed
the
dio_read_verify_cleanup
branch
from
e85ba3d to
ee0c601
Compare
Fine by me. I updated the ordering again. |
amotin
approved these changes
Dec 4, 2024
amotin
added
Status: Accepted
behlendorf
approved these changes
Dec 4, 2024
behlendorf
added
Status: Revision Needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a recent CI ZTS test failure on FreeBSD 14 for the dio_read_verify test case. The failure reported there was no ARC reads while the buffer wes being manipulated. All checksum verify errors for Direct I/O reads are rerouted through the ARC, so there should be ARC reads accounted for. In order to help debug any future failures of this test case, the order of checks has been changed. First there is a check for DIO verify failures for the reads and then ARC read counts are checked.
This PR also contains general cleanup of the comments in the test script.
Reordering some calls in dio_read_verify test to help with debugging recent CI test failure in FreeBSD 14.
Motivation and Context
This change will allow for further debugging in the event of another
dio_read_verifytest failure in the CI runs. It is helpful first to see if there are DIO read verify failures before checking if there are any ARC reads.Description
Reordered checks in
dio_read_verify. First there are checks to make sure there are in fact DIO read verify failures before checking there are ARC reads. There always should be DIO read verify failures, as the buffer is constantly being manipulated while Direct I/O reads are taking place in the test.How Has This Been Tested?
Tested locally on Linux kernel 4.18.0-408.el8.x86_64.
Ran
directZTS tests for multiple iterations without failure after updating this test case.Types of changes
Checklist:
Signed-off-by.